fixed shortcut issue

[shashank-0-0]

Fixes #3957

The issue was with navigateTo(), which breaks the back stack (https://stackoverflow.com/questions/71525493/bottom-navigation-bar-malfunctions-when-navigating-from-a-fragment)
so used the NavigationUI API to navigate.

Screenshots

Record_2024-07-27-18-52-11.mp4

ready to rework if changes are needed.

[kelson42]

@MohitMaliDeveloper What is the status here?

[MohitMaliFtechiz]

@shashank-0-0 Thank you for the PR, can you please also fix the GET_CONTENT shortcut not working when the application is in the background? It works when the application is freshly opened, but not if I open it when the application is in background.

You need handle this intent in the onNewIntent method in KiwixMainActivity. Also can you please write the automated test case for this fix so that we can avoid this type of errors in future. If you need any kind of help in testing let me know.

[shashank-0-0]

@shashank-0-0 Thank you for the PR, can you please also fix the GET_CONTENT shortcut not working when the application is in the background? It works when the application is freshly opened, but not if I open it when the application is in background.

You need handle this intent in the onNewIntent method in KiwixMainActivity. Also can you please write the automated test case for this fix so that we can avoid this type of errors in future. If you need any kind of help in testing let me know.

@MohitMaliFtechiz please correct me if i am wrong , Isn't oncreate always called when you open a static shortcut ? so is it necessary to handle it in onNewIntent ?

kiwix_shortcut.mp4

[MohitMaliFtechiz]

@shashank-0-0 No, onCreate will not always call when the application is already in the background. It will only be called when the application is fully closed(not in the background). When it is in the background and we open a static shortcut,t the onNewIntent method will call.

media_20241104_155720_4821255378590183623.mp4

[shashank-0-0]

@shashank-0-0 No, onCreate will not always call when the application is already in the background. It will only be called when the application is fully closed(not in the background). When it is in the background and we open a static shortcut,t the onNewIntent method will call.

media_20241104_155720_4821255378590183623.mp4

my bad , Got it pushing the change.

[MohitMaliFtechiz]

Thanks for the changes. Can you please write the automated test case for this? I will be available for any help if you need in this.

[shashank-0-0]

Thanks for the changes. Can you please write the automated test case for this? I will be available for any help if you need in this.

okay!!

[shashank-0-0]

@MohitMaliFtechiz I have written instrumented test for getContent shortcut can u review it, and let me know if changes are needed .

[MohitMaliFtechiz]

@shashank-0-0 Thanks for creating the instrumentation test cases, the code and test are good, can you please improve the commit history? there are some unrelevent commits.

[MohitMaliFtechiz]

@shashank-0-0 Thanks, LGTM

[kelson42]

CI does not pass

[MohitMaliFtechiz]

@shashank-0-0 Can you please rebase? @kelson42 The CI is failing due to #4073 which we already fixed.