-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: The UI showing incorrect colors in night mode. #3998
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3998 +/- ##
============================================
- Coverage 58.22% 58.09% -0.14%
+ Complexity 1601 1598 -3
============================================
Files 314 314
Lines 13050 13050
Branches 1657 1657
============================================
- Hits 7598 7581 -17
- Misses 4344 4364 +20
+ Partials 1108 1105 -3 ☔ View full report in Codecov by Sentry. |
12556bc
to
ed22e9d
Compare
@MohitMaliDeveloper What is the status here? Have all the colors cleanuped so we have clear light/dark modes without custom colors? |
@kelson42 Yes. I was waiting for your reply on #3736 (comment), I have put the screenshots of the UI of donation popup in the PR description, if it looks okay to you than this PR is ready for review. |
ed22e9d
to
8d23eb6
Compare
Please don't use any custom colors at all. Rely on default themes. I will treat the donate box separatly. |
8d23eb6
to
6d09c7c
Compare
@kelson42 We are not using any custom colors in this, we are using the default theme color in our project. In this PR I have removed the custom colors from the project.
Okay, I have created a separate PR for this #4012. |
…eason related to the OverflowMenuButton (the three-dot default Android button) width.
Fixes #3991
Apart from these, all other views use the Android standard colors in our project.