Fixed: Opening with Kiwix a ZIM file (just after download) from Firefox fails. #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ox fails. * Fixed an issue where the ZIM file would not load when opened directly from the file manager. * Fixed the issue with opening a ZIM file from the browser's download screen.
…can avoid this type of error in the future.
|
@MohitMaliDeveloper Please republish in testing once merged. |
|
@MohitMaliFtechiz Pretty sure there is a problem with the CI |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3999 +/- ##
============================================
+ Coverage 57.85% 57.90% +0.04%
- Complexity 1600 1601 +1
============================================
Files 314 314
Lines 13092 13109 +17
Branches 1663 1666 +3
============================================
+ Hits 7575 7591 +16
+ Misses 4411 4407 -4
- Partials 1106 1111 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@kelson42 The CI is green now. |
The application has been published in internal testing https://github.com/kiwix/kiwix-android/actions/runs/10970685528/job/30464854076. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3997
Fixes #3941
BeforeFix.mp4
AfterFix.mp4
screen-20240920-214043.mp4