Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Opening the zim file with kiwix fails to open(not showing the copy/move dialog). #4006

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Sep 23, 2024

  1. Fixed: Opening the zim file with kiwix fails to open(not showing the …

    …copy/move dialog).
    
    * The issue occurred because the logic for opening ZIM files was inside the KiwixReaderFragment, and if the user was on any other screen while using the application, this code was not triggered. As a result, the copy/move dialog was not shown. To resolve this, we moved the functionality to the KiwixMainActivity.
    MohitMaliDeveloper committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    bc394dc View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Fixed: ZIM file not moving/Copying on Android 14 tablet.

    * When opening the ZIM file via file picker or deep linking, we were obtaining the file path using the getZimFileFromUri() method to perform the renaming for the move functionality. However, on Android 14 tablets, the URI was not resolved correctly by this method, leading to a "ZIM file not found" error.
    * To fix this issue, we removed the dependency on the `getZimFileFromUri()` method in the Play Store variant, as future Android versions may handle URIs differently. We refactored our code so that the copy/move functionality works independently of this method and now works directly with Android's provided URI.
    MohitMaliDeveloper committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0596a60 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a296523 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    572dd0a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7be8eff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fbb947c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    c333e67 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Added a test case to verify file opening from the file manager.

    * Improved the test case to remove the file from the emulator to free up device storage, as we do not have access to this file after running the test case, and it will remain in storage.
    MohitMaliDeveloper committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    564d867 View commit details
    Browse the repository at this point in the history