-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Opening the zim file with kiwix fails to open(not showing the copy/move dialog). #4006
Draft
MohitMaliFtechiz
wants to merge
8
commits into
main
Choose a base branch
from
Fix#3941
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 23, 2024
-
Fixed: Opening the zim file with kiwix fails to open(not showing the …
…copy/move dialog). * The issue occurred because the logic for opening ZIM files was inside the KiwixReaderFragment, and if the user was on any other screen while using the application, this code was not triggered. As a result, the copy/move dialog was not shown. To resolve this, we moved the functionality to the KiwixMainActivity.
Configuration menu - View commit details
-
Copy full SHA for bc394dc - Browse repository at this point
Copy the full SHA bc394dcView commit details
Commits on Sep 24, 2024
-
Fixed: ZIM file not moving/Copying on Android 14 tablet.
* When opening the ZIM file via file picker or deep linking, we were obtaining the file path using the getZimFileFromUri() method to perform the renaming for the move functionality. However, on Android 14 tablets, the URI was not resolved correctly by this method, leading to a "ZIM file not found" error. * To fix this issue, we removed the dependency on the `getZimFileFromUri()` method in the Play Store variant, as future Android versions may handle URIs differently. We refactored our code so that the copy/move functionality works independently of this method and now works directly with Android's provided URI.
Configuration menu - View commit details
-
Copy full SHA for 0596a60 - Browse repository at this point
Copy the full SHA 0596a60View commit details -
Configuration menu - View commit details
-
Copy full SHA for a296523 - Browse repository at this point
Copy the full SHA a296523View commit details -
Configuration menu - View commit details
-
Copy full SHA for 572dd0a - Browse repository at this point
Copy the full SHA 572dd0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7be8eff - Browse repository at this point
Copy the full SHA 7be8effView commit details -
Configuration menu - View commit details
-
Copy full SHA for fbb947c - Browse repository at this point
Copy the full SHA fbb947cView commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c333e67 - Browse repository at this point
Copy the full SHA c333e67View commit details
Commits on Sep 28, 2024
-
Added a test case to verify file opening from the file manager.
* Improved the test case to remove the file from the emulator to free up device storage, as we do not have access to this file after running the test case, and it will remain in storage.
Configuration menu - View commit details
-
Copy full SHA for 564d867 - Browse repository at this point
Copy the full SHA 564d867View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.