Disabled the dependencies metadata from Singed APK for kiwix app. #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4057 +/- ##
============================================
+ Coverage 57.84% 57.95% +0.11%
- Complexity 1515 1518 +3
============================================
Files 315 315
Lines 13161 13161
Branches 1676 1676
============================================
+ Hits 7613 7628 +15
+ Misses 4448 4432 -16
- Partials 1100 1101 +1 ☔ View full report in Codecov by Sentry. |
MohitMaliFtechiz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue #4053
See #4053 (comment)
We have disabled the dependencies metadata from the signed APK since this APK we are posting on IzzyOnDroid, GitHub, and our website so the metadata is not needed for this. For the app bundle: We have kept the dependencies metadata since it will upload on the Google PlayStore where metadata is required.