-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opening new tabs on macos(#518) #536
Fix opening new tabs on macos(#518) #536
Conversation
@BPerlakiH Thank you. |
@BPerlakiH Please fix the two weaknesses you have listed so the PR is feature completed. Once done, please update PR comment and request new review. |
@BPerlakiH Rebasing to benefit of the new CI |
…erlakiH/Kiwix into fix/518-open-link-in-new-tab-on-macos
@BPerlakiH Oops, I am so sorry I did not see you have this PR already opened for the external URL alert issue. So I made a PR (#539) and merged it, because I created the issue in the first place. Apologies for the merge conflict As I have communicated with @kelson42, I won't have any capacity for PR reviews in the foreseeable future, so I'll give this one a quick look, and let him decide what to do |
@automactic Thanks for having a quick look |
@tvision251 I would like to have your review on this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not judge the can and for the moment can not test it on my own. But if the points revealed by @automactic are fixed, then should be OK.
Fixes #518: Open link "in a new window" on macOS.
Partially based on #526
Known issues: