Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the localization #537

Merged
merged 20 commits into from
Nov 22, 2023
Merged

Conversation

tvision251
Copy link
Contributor

@tvision251 tvision251 commented Nov 14, 2023

Fixes #24

@kelson42
Copy link
Contributor

@tvision251 Thank you, please secure Codefactor is green.

@kelson42
Copy link
Contributor

kelson42 commented Nov 14, 2023

@translatewiki @Nikerabbit would the strings like they are here defined, something you could import and export with translatewiki bot?

@tvision251
Copy link
Contributor Author

@tvision251 Thank you, please secure Codefactor is green.

It's done

@tvision251
Copy link
Contributor Author

@translatewiki @Nikerabbit would the strings like they are here defined, something you could import and export with translatewiki bot?

We can update the following strings for other languages(The left side represents the key and the right one is the value).
https://github.com/kiwix/apple/blob/a5bc9053f508612a03ac8cb1d4f02e78e7016686/Support/en.lproj/Localizable.strings

Here is the empty file for Spanish(example).
https://github.com/kiwix/apple/blob/a5bc9053f508612a03ac8cb1d4f02e78e7016686/Support/es.lproj/Localizable.strings

i.e.

/* Library Refresh Error */
"Error retrieving library data." = "Error al recuperar los datos de la biblioteca.";

...

"Download Completed" = "Descarga completa";

@Nikerabbit
Copy link

Yes, the .strings format should be supported.

@kelson42
Copy link
Contributor

@tvision251 It seems your last commit has broken again Codefactor part of the CI

@tvision251
Copy link
Contributor Author

@tvision251 It seems your last commit has broken again Codefactor part of the CI

fixed

@kelson42
Copy link
Contributor

@automactic I would like to merge this one in prioriy as this is mostly a no-brainer and would allow TW community to start to work on translations quickly.

@kelson42
Copy link
Contributor

Rebased on main to benefit of the new CI

@kelson42
Copy link
Contributor

@BPerlakiH Could you please review this PR?

BPerlakiH
BPerlakiH previously approved these changes Nov 20, 2023
@kelson42 kelson42 merged commit 5285e17 into kiwix:main Nov 22, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Localization
4 participants