Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated libkiwix methods #805

Closed
kelson42 opened this issue Feb 27, 2022 · 2 comments · Fixed by #831
Closed

Stop using deprecated libkiwix methods #805

kelson42 opened this issue Feb 27, 2022 · 2 comments · Fixed by #831

Comments

@kelson42
Copy link
Collaborator

libkiwix 10.x.y have deprecated many methods and function which are still in used in Kiwix Desktop. This has two consequences:

  • Many warning at Kiwix Desktop compilation time
  • Stop us to removed these old/deprecated primitives in future libkiwix releases.

Would be beneficial to remove the usage of these deprecated methods and use modern/new API of libkiwix.

The effort has already been made in Kiwix Tools, see kiwix/kiwix-tools#535 and this PR might help to know what to do with Kiwix Desktop.

@kelson42
Copy link
Collaborator Author

@juuz0 Have you been able to have a look to this ticket? We are planning release of libkiwix 10.1.0 and I wonder if we would have a chance to implement libkiwix/issues/430 in it.

@juuz0
Copy link
Collaborator

juuz0 commented Mar 24, 2022

@kelson42 Yes, been working on it. I should be able to do this and other PR by Saturday (college exam on Friday)

juuz0 added a commit that referenced this issue Apr 12, 2022
This replaces the deprecated Reader and Favicon functions from libkiwix

kiwix::Reader functions are converted to use zim::Archive
Favicon functions are converted to use Illustration
Fix #805
juuz0 added a commit that referenced this issue Apr 12, 2022
This replaces the deprecated Reader and Favicon functions from libkiwix

kiwix::Reader functions are converted to use zim::Archive
Favicon functions are converted to use Illustration
Fix #805
juuz0 added a commit that referenced this issue Apr 13, 2022
This replaces the deprecated Reader and Favicon functions from libkiwix

kiwix::Reader functions are converted to use zim::Archive
Favicon functions are converted to use Illustration
Fix #805
juuz0 added a commit that referenced this issue May 7, 2022
This replaces the deprecated Reader and Favicon functions from libkiwix

kiwix::Reader functions are converted to use zim::Archive
Favicon functions are converted to use Illustration
Fix #805
juuz0 added a commit that referenced this issue May 17, 2022
This replaces the deprecated Reader and Favicon functions from libkiwix

kiwix::Reader functions are converted to use zim::Archive
Favicon functions are converted to use Illustration
Fix #805
juuz0 added a commit that referenced this issue May 17, 2022
This replaces the deprecated Reader and Favicon functions from libkiwix

kiwix::Reader functions are converted to use zim::Archive
Favicon functions are converted to use Illustration
Fix #805
@kelson42 kelson42 modified the milestones: 2.3.0, 2.2.2 Jun 3, 2022
mgautierfr pushed a commit that referenced this issue Jun 16, 2022
This replaces the deprecated Reader and Favicon functions from libkiwix

kiwix::Reader functions are converted to use zim::Archive
Favicon functions are converted to use Illustration
Fix #805
mgautierfr pushed a commit that referenced this issue Jun 16, 2022
This replaces the deprecated Reader and Favicon functions from libkiwix

kiwix::Reader functions are converted to use zim::Archive
Favicon functions are converted to use Illustration
Fix #805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants