-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the HTMLInputElement:webkitdirectory
API
#422
Conversation
Tested and working well on Firefox and Edge Legacy. Doesn't interfere with IE11 legacy file picking, and doesn't prevent use of newer APIs if available. Need to check interaction with Electron and NWJS. TODO: put repeated code into a function. |
It seems the API has poor support on Android even though |
No support on any mobile browser: https://caniuse.com/input-file-directory. |
Prevented false-positive detection on iOS and Android, and tested on BrowserStack. |
I've now made a single function to process a directory of files, whether it is provided by It would be nice if the list of files were retained and displayed on reload of the app. Assuming this is possible (it's just a cookie list), then clidking on a file in the list should open the directory picker in Firefox. This would put us at near parity between the two APIs. |
Last thing to do is make it so refresh button opens directory dialogue. |
Checks:
|
All manual test passed. Ready to merge. One minor issue noted above has been noted in #427. |
Fixes #421.