Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new function in uiUtil.js to navigate to the opened ZIM in order to reduce redundancy #1248

Closed
D3V-D opened this issue May 4, 2024 · 5 comments
Closed

Create new function in uiUtil.js to navigate to the opened ZIM in order to reduce redundancy #1248

D3V-D opened this issue May 4, 2024 · 5 comments
Assignees
@D3V-D
Labels
backend cleanup
Milestone
v4.1

Comments

@D3V-D
Copy link
Contributor

D3V-D commented May 4, 2024

See title.

Already made a function in app.js, and it's being used in at least one other place within the uiUtil.js file as well.
@D3V-D
Copy link
Contributor Author

D3V-D commented May 4, 2024

@Jaifroid let me know if any special details; otherwise please assign me

@Jaifroid Jaifroid added this to the v4.1 milestone May 4, 2024
@Jaifroid
Copy link
Member

Jaifroid commented May 4, 2024

No special details! Thanks for opening the issue.

Jaifroid pushed a commit that referenced this issue May 6, 2024
@D3V-D
Move returnToCurrentPage function to uiUtil.js #1248 (#1249)
affca03 
Signed off by @D3V-D.
@D3V-D
Copy link
Contributor Author

D3V-D commented May 6, 2024

@Jaifroid do you want to close this issue?

@Jaifroid
Copy link
Member

Jaifroid commented May 6, 2024

Yes, not sure why it didn't auto-close!

@Jaifroid Jaifroid closed this as completed May 6, 2024
@D3V-D
Copy link
Contributor Author

D3V-D commented May 7, 2024

I believe the issue was not linked to the PR. @Jaifroid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@D3V-D D3V-D

Labels
backend cleanup
Projects
None yet
Milestone
v4.1
Development

No branches or pull requests
2 participants
@Jaifroid @D3V-D