Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait longer for the SW to cache assets before rebooting if the SW fails to register #1255

Closed
Tracked by #1263
Jaifroid opened this issue May 23, 2024 · 0 comments · Fixed by #1272
Closed
Tracked by #1263
Assignees
Milestone

Comments

@Jaifroid
Copy link
Member

The app contains code to cache its own assets, according to the SW specification, but it occasionally has to reboot itself when the SW fails to register. In KJS, this reboot is being issued too quickly, and sometimes the app gets into a loop whereby it reboots before assets have finished caching, causing a boot loop in rapid succession. I saw this some time ago in the PWA, and slowed the process down by giving it more time. Something similar should be added here -- or that whole code needs some debugging. I've only noticed this when testing on iOS on an iPhone (not on an iPad). It's not a target for this app, but it does expose an issue that should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant