Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In ServiceWorker mode, always set the src of the iframe instead of using the displayArticleInForm function #382

Closed
mossroy opened this issue May 29, 2018 · 0 comments
Closed

In ServiceWorker mode, always set the src of the iframe instead of using the displayArticleInForm function #382

mossroy opened this issue May 29, 2018 · 0 comments
Assignees
@mossroy
Labels
enhancement
Milestone
v2.3

Comments

@mossroy
Copy link
Contributor

mossroy commented May 29, 2018

The displayArticleInForm is used, even in ServiceWorker mode, when an article is opened programmatically (welcome page, after a search, random etc).
But it would be simpler (and more consistent) to simply set the src of the iframe in these cases, and let the ServiceWorker do the job (as it already does when the user clicks on a link inside an article).
It also seems to significantly improve performance on complex pages (see #381)
@mossroy mossroy self-assigned this May 29, 2018
@mossroy mossroy mentioned this issue May 29, 2018
Closed
@mossroy mossroy added this to the v2.3 milestone May 29, 2018
mossroy added a commit that referenced this issue May 30, 2018
@mossroy
In ServiceWorker mode, set the iframe src to display articles.
294facd 
Instead of calling displayArticleInForm like in jQuery mode.
I also removed some tests on jQuery/ServiceWorker modes in displayArticleInForm, as this function is now only used in jQuery mode.
And I renamed it to displayArticleContentInIframe

Fixes #382
@mossroy mossroy mentioned this issue May 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossroy mossroy

Labels
enhancement
Projects
None yet
Milestone
v2.3
Development

No branches or pull requests
1 participant
@mossroy