Add a spinner, in Service Worker mode, when browsing to another article. #155
Conversation
So that the user knows his click is being processed. Fixes #135
| if (contentInjectionMode === 'serviceworker') { | ||
| // In Service Worker mode, we want to display a spinner | ||
| // when the user clicks on a link | ||
| // We only do that when the click is somewhere inside a <a> tag |
There was a problem hiding this comment.
Is that really a safe way? We could wait for a message from the service worker (that is sent as soon as the service worker starts loading the article).
There was a problem hiding this comment.
You're right : it's not a safe way at all. It was just an easy way to do a first version.
In fact, I would have expected the browser to inform the user by itself that a ServiceWorker is working. Just like it informs the user when some content is downloading.
It seems to be the case on Chromium, Firefox dev edition, but not on Firefox OS.
I should investigate if there is a way to have this built-in feedback on Firefox OS too, instead of trying to do it by hand.
|
I think this is good to merge for now, perhaps turn the comment above into an issue. |
|
I close this old PR. It was not well tested, and I'm not sure if it was FirefosOS-specific. |
So that the user knows his click is being processed.
Fixes #135