Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically fallback to jQuery mode if the SW fails to register. #424

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

mossroy
Copy link
Contributor

@mossroy mossroy commented Sep 22, 2018

Fixes #405

@Jaifroid
Copy link
Member

Jaifroid commented Sep 22, 2018

EDIT: This report shows the previous behaviour. It is now fixed by this PR.

Just tested on Firefox Quantum, Chromium and Edge:

  • On Chromium and Edge, I get a broken and unusable app after switching to Service Worker mode when using the file:// protocol. I am allowed to switch to this mode, even thought the first API status is orange, and the mode remains selected, even thought the API remains orange. Switching back to jQuery mode does not correct the situation -- the app remains unusable until I reload.

  • On Firefox Quantum, it also allows me to turn on Service Worker mode in file:// protocol, even though the first API status is orange, and it remains selected despite not working. However, switching back to jQuery mode allows the app to continue functioning as normal.

Copy link
Member

@Jaifroid Jaifroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now tested on all four main browsers (including IE), and this PR fixes the issue. It successfully prevents selection of SW mode if the browser doesn't support it in the file:// context (which is the context I tested).

@mossroy mossroy force-pushed the fallback-to-jquery-if-SW-fails-to-register branch from ff59a86 to 922d19a Compare September 22, 2018 10:57
@mossroy mossroy merged commit 666982b into master Sep 22, 2018
@mossroy mossroy deleted the fallback-to-jquery-if-SW-fails-to-register branch September 22, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants