Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check offline files list through CI #774

Merged
merged 6 commits into from
Jan 11, 2022

Conversation

Jaifroid
Copy link
Member

Testing CI solution for #772 .

@Jaifroid Jaifroid added the tests label Nov 23, 2021
@Jaifroid Jaifroid added this to the v3.3 milestone Nov 23, 2021
@Jaifroid Jaifroid self-assigned this Nov 23, 2021
@Jaifroid
Copy link
Member Author

Script confirmed to be working via pushing incorrect list. Screenshots show: 1. script failing due to missing file; 2. script passing.

image

image

@Jaifroid
Copy link
Member Author

Jaifroid commented Nov 23, 2021

Please note this PR is based on #771 and that PR should be merged first. It will only be possible to review this properly once that PR is merged and this one is (if necessary) rebased on master.

@Jaifroid Jaifroid force-pushed the Check-offline-files-list-through-CI branch from ae015a6 to 56667db Compare January 9, 2022 09:58
@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 9, 2022

Rebased on master.

@Jaifroid Jaifroid marked this pull request as ready for review January 9, 2022 10:23
@Jaifroid Jaifroid requested a review from mossroy January 9, 2022 10:35
Copy link
Contributor

@mossroy mossroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could no test, and do not know PowerShell enough to really review.
But the logic looks fine and I know you tested it.

scripts/Check-OfflineFilesList.ps1 Show resolved Hide resolved
.github/workflows/CI.yml Show resolved Hide resolved
@Jaifroid Jaifroid merged commit 3ffd96d into master Jan 11, 2022
@Jaifroid Jaifroid deleted the Check-offline-files-list-through-CI branch January 11, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a step in our CI to check the list of pre-cached files for the PWA-ServiceWorker
2 participants