Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to include new implementation #792

Merged
merged 11 commits into from
Jan 15, 2022

Conversation

Jaifroid
Copy link
Member

@Jaifroid Jaifroid commented Jan 9, 2022

This is a follow-on from #771, to provide some cleanup of documentation especially regarding the new implementation.

Initial edits.
@Jaifroid Jaifroid added this to the v3.3 milestone Jan 9, 2022
@Jaifroid Jaifroid self-assigned this Jan 9, 2022
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Jaifroid Jaifroid marked this pull request as ready for review January 13, 2022 11:25
@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 13, 2022

@mossroy I've attended to your comments, have made some other tweaks, and I've added a major new section on "Contributing".

If the "Contributing" section makes this too long for a README, I can put that section in a separate document and link to it.

Let me know when you are happy with the text. You can read it properly formatted here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Jaifroid
Copy link
Member Author

Actually @gaurav7019 has suggested on Slack that we need a CONTRIBUTING.MD file, so the text I've included in this PR relating to Contributing should be moved to such a file and expanded (to cover things like testing the Extension versions), with a link from here to there.

Copy link
Contributor

@mossroy mossroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new contributing section is much welcome (here or in another file)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Jaifroid
Copy link
Member Author

The contributing section is being moved to #800, and I'll transfer the one change to it from here to there. Please make any revisions on the version there rather than this one (which I'll shortly remove).

@Jaifroid
Copy link
Member Author

Ready for merge when you are. You might want to take look at the new "Limitations" section, which is where I've put the bit about not being able to open ZIM files without picking them, and also a mention of no full-text search. (so we don't keep getting questions asking for it).

@Jaifroid Jaifroid mentioned this pull request Jan 15, 2022
18 tasks
Copy link
Contributor

@mossroy mossroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please see if the Unit tests section is moved to CONTRIBUTING.md before the rebase/squash/merge

@Jaifroid Jaifroid merged commit 6275f29 into master Jan 15, 2022
@Jaifroid Jaifroid deleted the Update-documentation-to-include-new-implementation branch January 15, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants