Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Home Button #209

Closed
tim-moody opened this issue Jun 26, 2018 · 11 comments
Closed

Feature Request - Home Button #209

tim-moody opened this issue Jun 26, 2018 · 11 comments

Comments

@tim-moody
Copy link

Add optional parameter to kiwix-serve with the relative URL of the web server home page to permit kiwix-serve to return the user to a top level menu.

@mgautierfr
Copy link
Member

It is related to #17.

This is already possible to change the topbar without modifying kiwix-serve by provide your own html template and point to it with env var (Follow the links in #17). But this is really messy, an option should be better.

@kelson42
Copy link
Contributor

@tim-moody I support #17 but I have mixed feelings regarding this particular feature request. Would not that be simplier to just have a rewrite rule - in the reverse proxy - to make the kiwix-serve "ḧome" points wherever you want?

@tim-moody
Copy link
Author

maybe. are you saying I remove --nolibrarybutton from the startup and then trap the 'home' url in the proxy? what is the 'home' url? I'm proxying /kiwix/ to localhost:3000/kiwix/. Won't your suggestion mean also proxying /kiwix/ to /home/?

@kelson42
Copy link
Contributor

@tim-moody yes, per default the home button points to "/". So if url == "/" then redirects to somewhere else.

@tim-moody
Copy link
Author

but I have --urlRootLocation=/kiwix/ so I'm guessing you will return /kiwix/ not /, which is already redirected to /home

@kelson42
Copy link
Contributor

@tim-moody yes. Would that make it for you?

@tim-moody
Copy link
Author

probably if the home button returns /, even if --urlRootLocation=/kiwix/ then for us it would redirect to the home page.

@kelson42
Copy link
Contributor

@tim-moody The home button AFAIK return the value of --urlRootLocation if defined, / otherwise.

@tim-moody
Copy link
Author

then it doesn't work. I need /kiwix/ to go to localhost:3000/kiwix/ and a home button to go to /

@kelson42
Copy link
Contributor

@tim-moody If you really want an additional button, then #17 is definitly THE ticket.

@kelson42
Copy link
Contributor

I close this ticket because this is a use case for #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants