Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kiwix-serve] make the topbar customizable. #17

Open
mgautierfr opened this issue Mar 15, 2017 · 4 comments
Open

[kiwix-serve] make the topbar customizable. #17

mgautierfr opened this issue Mar 15, 2017 · 4 comments

Comments

@mgautierfr
Copy link
Member

At BSF, we need to change how the topbar is displayed. (Css but also displayed buttons).

I've got a working version, but it is based on some kind of hidden feature of the last kiwix-serve/kiwix-lib allowing to change the embedded resources at runtime with env var.
It's working but it is not perfect and error prone. (ideascube/ideascube#590 and ideascube/ansiblecube#43)

On top of it, we will end to rewrite a part of the topbar to make it more mobile friendly. (kiwix/kiwix-xulrunner#336)
It could be a good opportunity to think about how we add the topbar.

@kelson42
Copy link
Contributor

kelson42 commented Aug 7, 2019

@mgautierfr We have meanwhile rewritten the topbar in a more friendly manner. I wonder a bit how such a feature would/could looks like, considering that it should probably deal with HTML/CSS/JS/pictures.

@kelson42
Copy link
Contributor

kelson42 commented Feb 3, 2022

@mgautierfr I get once kiwix/libkiwix#394 is implemented, we could just use a similar approach like kiwix/libkiwix#571 ?!

@kelson42
Copy link
Contributor

Moving this task to @veloman-yunkan, this is IMO now straigt and trivial to implement this option, once kiwix/libkiwix#716 will be merged.

@kelson42
Copy link
Contributor

kelson42 commented Nov 26, 2022

We should not forget to update the README.md

@kelson42 kelson42 modified the milestones: 3.5.0, 3.6.0 Feb 10, 2023
@kelson42 kelson42 modified the milestones: 3.6.0, 3.7.0 Sep 30, 2023
@kelson42 kelson42 modified the milestones: 3.7.0, 3.8.0 Mar 5, 2024
@kelson42 kelson42 removed this from the 3.8.0 milestone May 30, 2024
@kelson42 kelson42 added this to the 3.9.0 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants