Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getBestPublicIp for all valid ips #1132

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Add ip availability check in server start

c8a11be
Select commit
Loading
Failed to load commit list.
Open

Refactor getBestPublicIp for all valid ips #1132

Add ip availability check in server start
c8a11be
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 23, 2024 in 0s

32.65% of diff hit (target 41.43%)

View this Pull Request on Codecov

32.65% of diff hit (target 41.43%)

Annotations

Check warning on line 89 in src/server.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/server.cpp#L89

Added line #L89 was not covered by tests

Check warning on line 94 in src/server.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/server.cpp#L94

Added line #L94 was not covered by tests

Check warning on line 466 in src/server/internalServer.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/server/internalServer.cpp#L465-L466

Added lines #L465 - L466 were not covered by tests

Check warning on line 475 in src/server/internalServer.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/server/internalServer.cpp#L475

Added line #L475 was not covered by tests

Check warning on line 122 in src/server/internalServer.h

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/server/internalServer.h#L121-L122

Added lines #L121 - L122 were not covered by tests

Check warning on line 258 in src/tools/networkTools.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/tools/networkTools.cpp#L258

Added line #L258 was not covered by tests