-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opds categories feed #492
Merged
Merged
Opds categories feed #492
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
0a3d293
Broke Server.404 with /catalogBLABLABLA/root.xml
veloman-yunkan 5b272ac
Fixed handling of /catalogBLABLA/root.xml & alike
veloman-yunkan 1e0ff1f
Fixed the double colon in OPDS date string
veloman-yunkan 54b78ea
Moved gen_date_str() to tools/otherTools.cpp
veloman-yunkan 3c3cf08
Serving /catalog/v2/root.xml
veloman-yunkan b259afa
Library::getBooksCategories()
veloman-yunkan 2e53b51
Serving /catalog/v2/categories
veloman-yunkan a1520ce
Fixing the xenial build
veloman-yunkan feeb9f2
/catalog/v2/* XMLs are OPDS 1.2
veloman-yunkan 92c2de8
Enter InternalServer::m_library_id
veloman-yunkan 19b59fd
Serving /catalog/v2/entries
veloman-yunkan 208dece
Reordered several statements
veloman-yunkan 4aa3c79
Extracted get_search_filter()
veloman-yunkan 70d42ae
A small simplification
veloman-yunkan b60e3ff
RequestContext::get_optional_param()
veloman-yunkan 07252a1
/catalog/v2/entries is also a search endpoint
veloman-yunkan dfad1c3
/catalog/v2/searchdescription.xml
veloman-yunkan cdacc0c
/catalog/v2/entries going through OPDSDumper
veloman-yunkan 9ca6bd0
/catalog/v2/categories goes through OPDSDumper too
veloman-yunkan f886c8c
Root url is normalized once in the constructor
veloman-yunkan f179799
Reused InternalServer::search_catalog()
veloman-yunkan fa42cbc
Pagination info in /catalog/v2/entries
veloman-yunkan 312f2cb
Moved handle_catalog_v2*() methods into a new file
veloman-yunkan e799f2f
OPDSDumper::dumpOPDSFeed() works via mustache
veloman-yunkan dd60235
Fixed the self link in the output of /catalog/v2/entries
veloman-yunkan 78083f1
Moved OPDS templates under static/templates
veloman-yunkan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this data is pretty closed from the ones used in
dumpOPDSFeedV2
.Could be have "only one method" using two different templates ?
(Or maybe even better, one template with just the endpoint changing ? If possible)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's consider that after the new API is finalized. I don't want the old API to be a drag on the new API, and a premature attempt to share code between them will do just that.