Fixed the libkiwix build broken by the changed libzim search API #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didn't take any advantage of the new libzim search API. Just fixed the libkiwix build in the most straightforward way.
veloman-yunkan
force-pushed
the
lizim_search_api_change
branch
from
8d68581
to
cd02b4d
Compare
This was referenced May 15, 2021
mgautierfr
approved these changes
May 17, 2021
There was a problem hiding this comment.
Didn't take any advantage of the new libzim search API. Just fixed the libkiwix build in the most straightforward way.
Yes, and we probably won't do it as we want to remove the wrapper level (#430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #523
Didn't take any advantage of the new libzim search API. Just fixed the libkiwix build in the most straightforward way.