Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to c++17. #996

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Move to c++17. #996

merged 1 commit into from
Sep 14, 2023

Conversation

mgautierfr
Copy link
Member

@mgautierfr mgautierfr commented Aug 31, 2023

All our compilers should handle c++17. Let's move on.

Following of openzim/libzim#819
Fix #877

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (bde737f) 38.87% compared to head (983105c) 38.92%.

❗ Current head 983105c differs from pull request most recent head c38ab3e. Consider uploading reports for the commit c38ab3e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
+ Coverage   38.87%   38.92%   +0.04%     
==========================================
  Files          58       58              
  Lines        4000     4008       +8     
  Branches     2200     2204       +4     
==========================================
+ Hits         1555     1560       +5     
+ Misses       1101     1099       -2     
- Partials     1344     1349       +5     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTSG-IEDSAP-TM1


1 Looks better than simply good - I even dare say, almost perfect - to me

@kelson42
Copy link
Collaborator

kelson42 commented Sep 9, 2023

@mgautierfr You mean fixes #877 ?

All our compilers should handle c++17. Let's move on.
@kelson42 kelson42 merged commit e13324f into main Sep 14, 2023
10 checks passed
@kelson42 kelson42 deleted the cpp17 branch September 14, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gtest C++14 requirement (move to C++17)
3 participants