Revert ABI breakage in kiwix::Downloader::getDownloadIds() #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## version_12.1.1 #999 +/- ##
=================================================
Coverage ? 38.87%
=================================================
Files ? 58
Lines ? 4000
Branches ? 2200
=================================================
Hits ? 1555
Misses ? 1101
Partials ? 1344 ☔ View full report in Codecov by Sentry. |
|
The only thing I'm not sure about is if there's a plan to use this function in other const stuff and whether this causes issues with that. |
Closed
mgautierfr
force-pushed
the
const-abi
branch
from
9fd2f55
to
65b3c84
Compare
|
LGTM, Thanks Rebased on branch version_12.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing it to be
constis an ABI change since the symbol changes from_ZN5...to_ZNK5...(addition of "K").The other changes made in 18b7b5f are probably fine to keep since they don't appear to be used from what I can tell.
Fixes #998.