Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setting for client to update wireguard port. #46

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

elfkuzco
Copy link
Collaborator

Changes

  • make wireguard port configurable in case client wants to use a different port. Working on the ProtonVPN config downloader, I realized that the hard-coded port of 51820 didn't have to be fixed.
  • use better type annotations for generator function - fetch_tests
  • show error message on Docker APIError

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (0c088e1) to head (dffca52).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   69.66%   69.66%           
=======================================
  Files          30       30           
  Lines         946      946           
  Branches       93       93           
=======================================
  Hits          659      659           
  Misses        267      267           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elfkuzco elfkuzco requested a review from rgaudin August 31, 2024 21:21
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfkuzco elfkuzco merged commit 355dbfa into main Sep 2, 2024
4 checks passed
@elfkuzco elfkuzco deleted the worker-manager-add-wgport-setting branch September 2, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants