Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build macOS wheels #116

Merged
merged 3 commits into from
Mar 21, 2022
Merged

ci: build macOS wheels #116

merged 3 commits into from
Mar 21, 2022

Conversation

jrs65
Copy link
Collaborator

@jrs65 jrs65 commented Feb 28, 2022

No description provided.

@jrs65 jrs65 requested a review from kiyo-masui March 21, 2022 16:12
@jrs65
Copy link
Collaborator Author

jrs65 commented Mar 21, 2022

@kiyo-masui I figured I should actually get someone to review this (although the last few changes I pushed through myself such that everything wasn't quite so broken). If you want to try the mac binary wheels you can get them here (https://github.com/kiyo-masui/bitshuffle/actions/runs/2016851429) just download the "artifact".

@kiyo-masui
Copy link
Owner

Looked at the changes, and while I'm out of date on how the build system and CI works, nothing looks wrong to me.

I downloaded the wheels on my laptop and had no trouble getting them to work and pass all the tests (well, one failed because I didn't have h5dump installed, but after I installed it everything worked).

@jrs65
Copy link
Collaborator Author

jrs65 commented Mar 21, 2022

Great. I'll merge it now and make a new release which means that PyPI will get the wheels. I'm looking forward to not needing to wait for bitshuffle to build every time I build a new virtualenv!

@jrs65 jrs65 merged commit a60471d into master Mar 21, 2022
@jrs65 jrs65 deleted the build-macos-wheel branch March 21, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants