Fix lzf_filter compatibility with HDF5 > 1.8
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
force-pushed
the
fix-compiler-issues
branch
from
eb79dc9
to
8e78739
Compare
ljgray
force-pushed
the
fix-compiler-issues
branch
from
8e78739
to
b80f735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long-standing issue which only became obvious with recent compiler updates (see #153).
Changes to the structure of
H5Z_class_twere made in HDF5 versions 1.6, 1.8, and 1.8.3. The logic for selecting which class version to use inlzf_filter.cassumed the old class by default and only used the new class for HDF5 version 1.8.x. Based on #153, it seems that some compilers recently started treating warnings generated by this old class structure as errors, causing bitshuffle to fail to build.This PR also updates python versions used in CI main (python 3.8 will reach end of life soon) and tests wheels for the most recent version of HDF5.
Fixes
#153