Skip to content

Commit

Permalink
test: fix flaky test-vm-timeout-escape-nexttick
Browse files Browse the repository at this point in the history
Increase the VM timeout. If it is too small, the VM does not exit before
the code has a chance to create the problematic condition that causes
the timeout to be ignored.

Fixes: nodejs#24120

PR-URL: nodejs#24251
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
  • Loading branch information
Trott authored and kiyomizumia committed Nov 15, 2018
1 parent df2ab63 commit 5309bb3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/known_issues/test-vm-timeout-escape-nexttick.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ assert.throws(() => {
nextTick,
loop
},
{ timeout: common.platformTimeout(5) }
{ timeout: common.platformTimeout(10) }
);
}, {
code: 'ERR_SCRIPT_EXECUTION_TIMEOUT'
Expand Down

0 comments on commit 5309bb3

Please sign in to comment.