-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't report issue related to invalid position #22
Conversation
1cd092f
to
d442b7c
Compare
I really want to understand what kind of problem this is because in content check, each issue is quite important; otherwise, they cannot be connected. Also, I hope this fix preferably doesn't alter the condition logic; just skipping Reportf will suffice. func (r *runner) Reportf(pos token.Pos, format string, args ...interface{}) {
if pos..IsValid() {
r.pass.Reportf(pos, format, args...)
}
} |
087e6b2
to
66970b8
Compare
66970b8
to
7fdfd4d
Compare
I improved the PR to try to find the closest valid position. |
f4311de
to
b08c735
Compare
LGTM |
Fixes #21