Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #294 - reverse search crash - the tests still pass, but library doesn't crash #295

Closed
wants to merge 3 commits into from

Conversation

vsajip
Copy link
Contributor

@vsajip vsajip commented Oct 22, 2019

I commented out the assertion which was causing the problem reported in #294, and added the simple program which was causing the crash.

@gwenn
Copy link
Collaborator

gwenn commented Oct 22, 2019

The assert should not be removed.
Would you mind testing PR #296 ?
And close this PR.
Thanks.

@gwenn gwenn added the invalid label Oct 22, 2019
@vsajip vsajip closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants