Use nix APIs for umask munging in history module
#616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some unsafe code by using `nix`'s APIs for setting `umask`s on the history files. This changes these function signatures to take and return `nix::sys::stat::Mode` instead of `c_int` which constrains the valid representations of the `mode` parameter to `umask` and `fchmod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unsafe code by using
nix's APIs for settingumasks onthe history files. This changes these function signatures to take and
return
nix::sys::stat::Modeinstead ofc_intwhich constrains thevalid representations of the
modeparameter toumaskandfchmod.This is a drive-by refactoring I noticed while mucking around with keybindings in #615.