Do not validate if the command is 'NewLine'

[sigmaSd]

NewLine is in my experience used when the user actually want to force a newline regardless of the result of the validation.

This pr exempt newline from validation.

demo: (I first hit enter each time then ctrl-s)

[gwenn]

Related to #379.

[gwenn]

I would prefer that we don't call validate in this case.
Something like:

diff --git a/src/command.rs b/src/command.rs
index b46c7d5..c16f966 100644
--- a/src/command.rs
+++ b/src/command.rs
@@ -25,6 +25,16 @@ pub fn execute<H: Helper>(
 ) -> Result<Status> {
     use Status::{Proceed, Submit};

+    match cmd {
+        Cmd::EndOfFile | Cmd::AcceptLine | Cmd::AcceptOrInsertLine { .. } | Cmd::Newline => {
+            if s.has_hint() || !s.is_default_prompt() {
+                // Force a refresh without hints to leave the previous
+                // line as the user typed it after a newline.
+                s.refresh_line_with_msg(None)?;
+            }
+        }
+        _ => {}
+    };
     match cmd {
         Cmd::CompleteHint => {
             complete_hint_line(s)?;
@@ -58,11 +68,6 @@ pub fn execute<H: Helper>(
             s.edit_overwrite_char(c)?;
         }
         Cmd::EndOfFile => {
-            if s.has_hint() || !s.is_default_prompt() {
-                // Force a refresh without hints to leave the previous
-                // line as the user typed it after a newline.
-                s.refresh_line_with_msg(None)?;
-            }
             if s.line.is_empty() {
                 return Err(error::ReadlineError::Eof);
             } else if !input_state.is_emacs_mode() {
@@ -119,12 +124,10 @@ pub fn execute<H: Helper>(
                 kill_ring.kill(&text, Mode::Append);
             }
         }
-        Cmd::AcceptLine | Cmd::AcceptOrInsertLine { .. } | Cmd::Newline => {
-            if s.has_hint() || !s.is_default_prompt() {
-                // Force a refresh without hints to leave the previous
-                // line as the user typed it after a newline.
-                s.refresh_line_with_msg(None)?;
-            }
+        Cmd::Newline => {
+            s.edit_insert('\n', 1)?;
+        }
+        Cmd::AcceptLine | Cmd::AcceptOrInsertLine { .. } => {
             let validation_result = s.validate()?;
             let valid = validation_result.is_valid();
             let end = s.line.is_end_of_input();
@@ -140,8 +143,7 @@ pub fn execute<H: Helper>(
                 ) => {
                     return Ok(Submit);
                 }
-                (Cmd::Newline, ..)
-                | (Cmd::AcceptOrInsertLine { .. }, false, _)
+                (Cmd::AcceptOrInsertLine { .. }, false, _)
                 | (Cmd::AcceptOrInsertLine { .. }, true, false) => {
                     if valid || !validation_result.has_message() {
                         s.edit_insert('\n', 1)?;

[sigmaSd]

done

[gwenn]

Thanks.

[sigmaSd]

Would you mind releasing a new version? I want to add this to deno repl

[gwenn]

I will try this week-end.
(small) breaking changes expected:

• https://github.com/kkawakam/rustyline/pull/608/files#diff-ddd2ca024d052bcf97316f938850cd4b69be4d7190015874afcc221fe42711ac
• 69518ce#diff-869adc680365c930a66ac6afcc025192ef540f78e5de8578f46be6c48e326b6d
• 9c46ae4#diff-9611b6e5bfac66ac0ba90a0c795189798e3f97a9e74174396ddda83db2487ec1

[sigmaSd]

Thanks!

[gwenn]

Version 10.0.0 released.