Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to windows-sys #753

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Migrate to windows-sys #753

merged 1 commit into from
Dec 16, 2023

Conversation

printfn
Copy link
Contributor

@printfn printfn commented Dec 15, 2023

The winapi crate is no longer maintained, so I've migrated rustyline to windows-sys.

total += count;

if rec.EventType == wincon::WINDOW_BUFFER_SIZE_EVENT {
if u32::from(rec.EventType) == console::WINDOW_BUFFER_SIZE_EVENT {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistency in windows-sys API ?

@gwenn
Copy link
Collaborator

gwenn commented Dec 16, 2023

cargo tree --target 'x86_64-pc-windows-gnu' | grep winapi
# nothing

@gwenn gwenn merged commit c01855a into kkawakam:master Dec 16, 2023
2 checks passed
@gwenn
Copy link
Collaborator

gwenn commented Dec 16, 2023

Thanks

@printfn printfn deleted the windows-sys branch December 16, 2023 09:55
@printfn
Copy link
Contributor Author

printfn commented Mar 6, 2024

Hi, I was wondering if you were planning on releasing an update to crates.io? It’d be nice to have recent merges like this one available 😊

@gwenn
Copy link
Collaborator

gwenn commented Mar 6, 2024

Version 14.0.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants