Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate destination address cairo_message #1339

Conversation

obatirou
Copy link
Collaborator

@obatirou obatirou commented Aug 9, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1338

What is the new behavior?

Destination address for cairo_message is checked to be well formatted


This change is Reviewable

@obatirou obatirou force-pushed the oba/validate-cairo-message-destination-address branch from 365c15c to 385d2b4 Compare August 9, 2024 09:18
@obatirou obatirou marked this pull request as ready for review August 9, 2024 09:24
@obatirou obatirou force-pushed the oba/validate-cairo-message-destination-address branch from 385d2b4 to e33353f Compare August 19, 2024 07:28
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obatirou obatirou merged commit 9dc1ce4 into kkrt-labs:main Aug 19, 2024
6 checks passed
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* prefer macro over `from_str`

* add macro + fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: parse destination EVM address in cairo_message
2 participants