Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable modexp #1429

Merged
merged 3 commits into from
Sep 20, 2024
Merged

feat: disable modexp #1429

merged 3 commits into from
Sep 20, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 20, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1422

What is the new behavior?

  • Disables the external call to the cairo1 class for modexp operations
  • Removes the legacy modexp files.

This change is Reviewable

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.9%. Comparing base (221b976) to head (a8ca5ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/kakarot/precompiles/precompiles.cairo 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1429     +/-   ##
=======================================
+ Coverage   62.3%   62.9%   +0.6%     
=======================================
  Files         51      49      -2     
  Lines       8591    8332    -259     
=======================================
- Hits        5355    5247    -108     
+ Misses      3236    3085    -151     
Flag Coverage Δ
62.9% <0.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

obatirou
obatirou previously approved these changes Sep 20, 2024
Copy link
Collaborator

@obatirou obatirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the documentation
Else seem gtm

@enitrat enitrat merged commit c7896d0 into main Sep 20, 2024
5 checks passed
@enitrat enitrat deleted the feat/disable-modexp branch September 20, 2024 14:00
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: remove modexp
2 participants