Added basic Firefox support #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+110
to
+111
| # firefox_options.set_preference("browser.link.open_newwindow", 3) | ||
| # firefox_options.set_preference("browser.link.open_newwindow.restriction", 0) |
There was a problem hiding this comment.
Any reason these lines are commented?
| # Force opening in new tabs | ||
| # firefox_options.set_preference("browser.link.open_newwindow", 3) | ||
| # firefox_options.set_preference("browser.link.open_newwindow.restriction", 0) | ||
|
|
There was a problem hiding this comment.
Found how to disable audio in Firefox as well, but couldn't find how to disable scrollbars or the other stuff that Chrome does (for now).
Suggested change
| # Disable unused/annoying features | |
| firefox_options.setPreference("media.volume_scale", "0.0") | |
|
I'm still a bit rookie in this area, but is it possible to test these stuff? For instance audio disable etc.? |
|
Great comments! I will merge this since another PR is on the way. I've added your points as items in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #69