Handle lowercase project ids #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `logger` API will not automatically flush logging before the BEAM exits, so we call logger_std_h:filesync/1 explicitly.
When getting the access keys for a repo, Bitbucket does not preserve the order of the access keys, so sort them before comparing.
The workzone plugin is known to be confused and silently ignore changes to projects when the project key is in lower case, so always convert to upper case.
|
Note to @klarna-incubator/kred-core reviewers: this has been tested internally at Klarna (see the |
Taddic
reviewed
Sep 20, 2022
| @@ -80,7 +80,7 @@ do_request(Method, Url, Body) -> | |||
| Type = "application/json", | |||
| Request = {Url, Headers, Type, Body}, | |||
There was a problem hiding this comment.
Maybe put _Body here so that warning_as_errors won't cause compilation to fail?
There was a problem hiding this comment.
True, but for some weird reason, rebar.config uses fail_on_warning, which I thinks is not a valid option.
{erl_opts , [fail_on_warning, debug_info]}.
There was a problem hiding this comment.
But Body is actually a function argument, so this is not a problem.
Taddic
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #34 (Workzone plugin does not handle lowercase project ids), and also bug #58 (bitbucket does not preserve ssh key order).