Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use $0.00 for price if price not defined, log info #14

Closed

Conversation

KthProg
Copy link

@KthProg KthProg commented Jun 5, 2024

Price can be undefined, CT does not require price on products. This currently crashes product import.

@KthProg KthProg changed the title use $0.00 for price is price not defined, log info use $0.00 for price if price not defined, log info Jun 5, 2024
@andreshernandez-e2x
Copy link
Collaborator

Hi @KthProg,

Thank you for the contribution. We currently work with Klaviyo maintaining this integration, at this time the way we handle PRs is by committing/reviewing changes internally (in a private repository) and then syncing those changes to this repo (see here for a previous instance of this).

We've already been notified by Klaviyo, so we'll take a look at this internally to get it merged (and ideally make it available in Connect) and we'll let you know when it's done. Thanks!

@KthProg
Copy link
Author

KthProg commented Jun 14, 2024

Awesome thank you very much. It may be a good idea to put that info on the contribution document?

Right now it just says to open a PR.

@andreshernandez-e2x
Copy link
Collaborator

We've merged your change and synced it to this repository, we're currently just waiting for commercetools to certify the Connect release.

Also, thanks for mentioning the contribution document. We've updated it reflect the current way of working for any future contributors.

@andreshernandez-e2x
Copy link
Collaborator

The latest version has been certified by commercetools and should be available now in Connect. With this changes have been completed, so I'll be closing this PR.

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants