Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separation of API, State, and Side Effects #160

Merged
merged 8 commits into from
May 1, 2024
Merged

Separation of API, State, and Side Effects #160

merged 8 commits into from
May 1, 2024

Commits on Apr 22, 2024

  1. Separation of API, State and Side Effects. 

    Largely left tests alone except for adding a couple and adjusting setup to accommodate changes.
    Evan Masseau committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6b15ddb View commit details
    Browse the repository at this point in the history

  2. Use consistent nullability pattern so we aren't converting between em… 

    …pty string and null with identifiers.

Added proper deserializing of the profile attributes store property
    Evan Masseau committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8ac144e View commit details
    Browse the repository at this point in the history

  3. There is indeed a better way to do that

    Evan Masseau committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    aeb1895 View commit details
    Browse the repository at this point in the history

  4. Renamed some of the new classes and added new tests for them

    Evan Masseau committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8b517d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Doc blocks, minor cleanup, naming conventions

    Evan Masseau committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    59ad817 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Fix nullability test 

    Don't need immutable profile to expose attributes, but would be good to expose single attribute getter
    Evan Masseau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c3ee926 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. First round of PR comments

    Evan Masseau committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c035374 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. missed another arg label

    Evan Masseau committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    639d905 View commit details
    Browse the repository at this point in the history