-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging branch for next major release 3.0.0 #161
Commits on May 1, 2024
-
Separation of API, State, and Side Effects (#160)
* Separation of API, State and Side Effects. Largely left tests alone except for adding a couple and adjusting setup to accommodate changes. * Use consistent nullability pattern so we aren't converting between empty string and null with identifiers. Added proper deserializing of the profile attributes store property * There is indeed a better way to do that * Renamed some of the new classes and added new tests for them * Doc blocks, minor cleanup, naming conventions * Fix nullability test Don't need immutable profile to expose attributes, but would be good to expose single attribute getter * First round of PR comments * missed another arg label --------- Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for 3c92609 - Browse repository at this point
Copy the full SHA 3c92609View commit details -
Set an alpha version number on this branch in case it gets pulled by …
…a snapshot jitpack build
Evan Masseau committedMay 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 643205c - Browse repository at this point
Copy the full SHA 643205cView commit details -
Remove deprecated lifecycle property (#156)
Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for 86f399c - Browse repository at this point
Copy the full SHA 86f399cView commit details -
Transition profile identifier keys to internal visibility (#155)
Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for 5d94168 - Browse repository at this point
Copy the full SHA 5d94168View commit details
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4a6f806 - Browse repository at this point
Copy the full SHA 4a6f806View commit details
Commits on May 6, 2024
-
Publish old value of a state property (#164)
Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for 99a60a6 - Browse repository at this point
Copy the full SHA 99a60a6View commit details
Commits on May 9, 2024
-
Rename these properties so it is clear what true and false mean. Fix …
…polarity of how we check background data (#166) Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for 93e5b4f - Browse repository at this point
Copy the full SHA 93e5b4fView commit details -
Added tests for publishing of the old value (#165)
* Added test coverage for publishing old value with change callback * Broadcast on reset, and tests * Reset as a cleanup step, not a setup step. --------- Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for c807b01 - Browse repository at this point
Copy the full SHA c807b01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b45e07 - Browse repository at this point
Copy the full SHA 9b45e07View commit details
Commits on May 22, 2024
-
Using token endpoint for profile requests when a push token is presen…
…t in SDK state (#168) * making token request if token is present * minor refactor * fixed tests * added some tests * removed push state when resetting * updated tests * fixed side effects tests * removed unused comment * updated readme * finally fixed tests * Fix some setup/teardown in tests to take care of isolation issues. (#169) Co-authored-by: Evan Masseau <> --------- Co-authored-by: Evan C Masseau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for be79c1c - Browse repository at this point
Copy the full SHA be79c1cView commit details
Commits on May 23, 2024
-
API Header Fix: Move attempt count increment to before we write reque…
…st headers into the url connection. (#170) Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for 08590d8 - Browse repository at this point
Copy the full SHA 08590d8View commit details
Commits on Jun 11, 2024
-
Merge branch 'master' into rel/3.0.0
# Conflicts: # README.md # docs/index.html # sdk/analytics/src/main/java/com/klaviyo/analytics/Klaviyo.kt # sdk/analytics/src/test/java/com/klaviyo/analytics/KlaviyoTest.kt # sdk/analytics/src/test/java/com/klaviyo/analytics/KlaviyoUninitializedTest.kt # sdk/analytics/src/test/java/com/klaviyo/analytics/networking/requests/KlaviyoApiRequestTest.kt # versions.properties
Evan Masseau committedJun 11, 2024 Configuration menu - View commit details
-
Copy full SHA for c2f4c3c - Browse repository at this point
Copy the full SHA c2f4c3cView commit details
Commits on Aug 20, 2024
-
setProfileAttribute should accept any Serializable value not just Str…
…ing (#179) * changing profile attribute to accept serializable * updating for 3.0 release * logging incorrectly typed profile attribute
Configuration menu - View commit details
-
Copy full SHA for a1d2789 - Browse repository at this point
Copy the full SHA a1d2789View commit details
Commits on Aug 21, 2024
-
Concurrent network observer fix (#180)
* using synchronized list for observers * adding concurreny safe structure to all observer instances * Refresh versions syntax for dependencies * removing concurrent suffix --------- Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for 1151ee2 - Browse repository at this point
Copy the full SHA 1151ee2View commit details
Commits on Aug 27, 2024
-
* Sending 503 through retry logic * removing version.properties unecessary changes * fixing http import
Configuration menu - View commit details
-
Copy full SHA for 56b0c14 - Browse repository at this point
Copy the full SHA 56b0c14View commit details
Commits on Sep 6, 2024
-
CHNL-6996 Proguard docs and consumer rules (#184)
* Adding consumer rules and updating docs * progaurd changes
Configuration menu - View commit details
-
Copy full SHA for f4dd259 - Browse repository at this point
Copy the full SHA f4dd259View commit details
Commits on Sep 10, 2024
-
Introduce a de-dupe mechanism for push notifications (#177)
* Introduce tag support so we have the option to de-dupe push notifications similar to how stock FCM sdk can. * adding constant id and null-checked notification tag --------- Co-authored-by: Evan Masseau <> Co-authored-by: Daniel Peluso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for adb5915 - Browse repository at this point
Copy the full SHA adb5915View commit details
Commits on Sep 12, 2024
-
CHNL-3990 Remove identifiers from state if format issues (#186)
* Remove identifiers from state if API reports format errors * pr comments * removing extraneous decoder test
Configuration menu - View commit details
-
Copy full SHA for e3c795e - Browse repository at this point
Copy the full SHA e3c795eView commit details
Commits on Sep 17, 2024
-
Exposing klaviyo SDK name and version privately (#185)
* added klaviyo sdk name and version * Update sdk/analytics/src/main/java/com/klaviyo/analytics/DeviceProperties.kt Co-authored-by: dan-peluso <[email protected]> * fixed some formatting * updated the SDK name to be non lazy --------- Co-authored-by: dan-peluso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1bdb857 - Browse repository at this point
Copy the full SHA 1bdb857View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1b368e9 - Browse repository at this point
Copy the full SHA 1b368e9View commit details
Commits on Sep 23, 2024
-
Refactor singleton service initializers (#172)
* Convert SystemClock to class * These shouldn't have been mocked in this test class, its masking a bug. * Remove unnecessary, slightly risky, object initializers in core. * Restore system clock to object -- I take it back, we don't have to get rid of objects, just have to be more particular about using object initializers. * KLog can be a singleton object, no risk there. * This simple fix would take care of the issue, but i still don't love KlaviyoApiClient being a singleton object that can hit an unrecoverable exception in its initializer... * Found a balanced solution for KlaviyoApiClient -- converting this to a class was complicated by the inner class, and besides it works well as a singleton. The initializer was the real problem, so I extract the listeners from the initializer and created a startService method. This is safe to run multiple times if the SDK is re-initialized. * Prefer this way: we don't need to wrap any of the code in this method body except the methods that are themselves protected anyway * Forgot to add back starting the service in these tests' setup * Naming convention things * First shot at a pre-init buffer for failed operations. Needs tests * Added test of in-memory slate * I don't like import * * Added comments, logging, and wrapped the retry operations in safeCall * Trivial: move error logging out of exception class. Now that we wrap all SDK functions in safeCall, it is more straightforward to log from there. * Allow ONLY handlePush to be buffered * Remove unused test * keep 3.0 version increment * don't add this back * never trust github * Update versions.properties --------- Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for 7038aa1 - Browse repository at this point
Copy the full SHA 7038aa1View commit details
Commits on Sep 26, 2024
-
Merge branch 'master' into rel/3.0.0
# Conflicts: # README.md # docs/index.html # sdk/core/src/main/java/com/klaviyo/core/lifecycle/KlaviyoLifecycleMonitor.kt # sdk/core/src/main/java/com/klaviyo/core/model/SharedPreferencesDataStore.kt # sdk/core/src/main/java/com/klaviyo/core/networking/KlaviyoNetworkMonitor.kt # versions.properties
Evan Masseau committedSep 26, 2024 Configuration menu - View commit details
-
Copy full SHA for 481bbcd - Browse repository at this point
Copy the full SHA 481bbcdView commit details
Commits on Oct 3, 2024
-
Automatically check push permission status on app resume (#188)
* Protect against double subscriptions * readme and migration guide updates --------- Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for dd59dbc - Browse repository at this point
Copy the full SHA dd59dbcView commit details
Commits on Oct 9, 2024
-
Move API revision to core config property pulled from build property (#…
…190) Co-authored-by: Evan Masseau <>
Configuration menu - View commit details
-
Copy full SHA for 97cd99e - Browse repository at this point
Copy the full SHA 97cd99eView commit details
Commits on Oct 16, 2024
-
[CHNL-12521] Looking for react-native strings to determine sdk name a…
…nd version for config (#191) * resource reading maven attmept * working resource share attempt * update log level * fixing unit tests and working resource sharing * pr comments * fixing config * replace bump version task with xml-based task * fixing unit test * fixing file pathing for composite builds * fixing bump version task * removing build config field from build.gradle * using readXml for default config * removing unused versionFor import
Configuration menu - View commit details
-
Copy full SHA for 6050a5d - Browse repository at this point
Copy the full SHA 6050a5dView commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 240435a - Browse repository at this point
Copy the full SHA 240435aView commit details
Commits on Oct 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dbe8395 - Browse repository at this point
Copy the full SHA dbe8395View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32d1dc6 - Browse repository at this point
Copy the full SHA 32d1dc6View commit details