Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User agent format update #195

Merged
merged 2 commits into from
Oct 30, 2024
Merged

User agent format update #195

merged 2 commits into from
Oct 30, 2024

Conversation

evan-masseau
Copy link
Contributor

@evan-masseau evan-masseau commented Oct 29, 2024

Minor user agent string format update to reflect the recent ability to override the SDK's name. This will allow our API monitoring boards, which depend upon the user agent, to differentiate klaviyo-[ios, android, react-native ... etc)

Description

Check List

  • Are you changing anything with the public API? - Nah
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you tested this change on real device?
  • Have you added unit test coverage for your changes? -- Coming
  • Have you verified that your changes are compatible with all Android versions the SDK currently supports?

Changelog / Code Overview

Use the configurable SDK name in the user agent, new format would look like:

Stock Android:
AndroidApp/1.2.3-beta (com.company.androidapp; build:15; Android 34) klaviyo-android/3.0.1

React Native Android
ReactApp/1.2.3-beta (com.cool_company.reactapp; build:15; Android 34) klaviyo-react-native/1.0.1

Test Plan

  • Unit test

Related Issues/Tickets

  • Monitoring improvements / nice to have

Copy link
Contributor

@dan-peluso dan-peluso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@evan-masseau evan-masseau merged commit ce74a1a into master Oct 30, 2024
6 checks passed
@evan-masseau evan-masseau deleted the ecm/user-agent-update branch October 30, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants