Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close stale issues via github action #96

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

jordan-griffin
Copy link
Contributor

Description

Just adds an update to our Github Actions workflow to mark issues as stale and close them out after a period of inactivity

Check List

  • Are you changing anything with the public API?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you tested this change on real device?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all Android versions the SDK currently supports?

Changelog / Code Overview

Test Plan

Related Issues/Tickets

@jordan-griffin jordan-griffin requested a review from a team as a code owner August 30, 2023 17:51
days-before-issue-stale: 14
days-before-issue-close: 10
stale-issue-label: 'stale'
stale-issue-message: 'This issue is stale due to inactivity. Please let us know if you are still encountering issues, otherwise this issue will automatically close in 4 days.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want to close in 4 days, then line 26 should be 4 not 10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 might be too short. If an issue is marked stale at the start of the weekend, it could be closed before anyone has a chance to respond to it. I totally chose 10 days pretty arbitrarily though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry i dont have a preference on how long, just that this message says 4 days but the number above isnt 4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh I totally missed that. Will change the message for now. Probably the same on the Swift SDK so will correct that too

@jordan-griffin jordan-griffin merged commit 3081ac7 into master Sep 5, 2023
2 checks passed
@jordan-griffin jordan-griffin deleted the jordan/2023-09-30/stale-issues-action branch September 5, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants