Attempting to fix CI builds #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 22, 2023 10:38
|
Open to ideas on how to fix this latest error on the ios side! |
…into fix-ci * 'fix-ci' of github.com:klaviyo/klaviyo-react-native-sdk: Separate files and interfaces for push, profile, events methods
…into fix-ci * 'fix-ci' of github.com:klaviyo/klaviyo-react-native-sdk: Updated to use klaviyo repo over Kenny's private repo (#11)
…into fix-ci * 'fix-ci' of github.com:klaviyo/klaviyo-react-native-sdk: Update Podfile Update Podfile
ajaysubra
approved these changes
Jan 3, 2024
| @@ -1385,4 +1385,4 @@ SPEC CHECKSUMS: | |||
|
|
|||
| PODFILE CHECKSUM: 4b9faf5e512fab6e8d87beb30570ec4d3bd884b9 | |||
|
|
|||
| COCOAPODS: 1.14.2 | |||
| COCOAPODS: 1.14.3 | |||
There was a problem hiding this comment.
I had this change too, wonder if we should all update to the latest since we'd be going back and forth on this file we didn't.
| @@ -1,2 +0,0 @@ | |||
| export NODE_BINARY=/Users/kenny.tsui/.nvm/versions/node/v18.16.0/bin/node | |||
There was a problem hiding this comment.
thanks for removing this
There was a problem hiding this comment.
interestingly, having this on my local caused the same error 65 message about hermes as I'm seeing in the CI output. And yet I am pretty sure I've set NODE_BINARY correctly now in this branch...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far I have fixed android (easy, just had to specify the right java version)
And fixed some ios issues such as specifying the right xcode version. Still can't get ios build to complete though.