Update to contribution guidelines #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-masseau
commented
Feb 27, 2024
evan-masseau
commented
Feb 27, 2024
evan-masseau
changed the title
ajaysubra
approved these changes
Feb 27, 2024
evan-masseau
commented
Feb 27, 2024
kennyklaviyo
reviewed
Mar 1, 2024
kennyklaviyo
reviewed
Mar 1, 2024
.github/ISSUE_TEMPLATE/bug.yml
Outdated
| validations: | ||
| required: true | ||
| - type: checkboxes | ||
| attributes: | ||
| label: Checklist | ||
| options: | ||
| - label: I have determined whether this bug is also reproducible in a vanilla project | ||
| - label: I have determined whether this bug is also reproducible in a vanilla project, such as the example app in this repository. |
There was a problem hiding this comment.
would it be overkill to add a checkbox for, i've read and understand the contributing policy or something to that effect? can be added to bugs and feature templates
kennyklaviyo
approved these changes
Mar 1, 2024
Co-authored-by: Kenny Tsui <[email protected]>
…vice verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates our contributing guide and issue templates per our discussions about streamlining and adding firmer direction about how to provide feedback.
Changelog / Code Overview
package-lock.jsonfilemissing-detailsoroff-topicissuesRelated Issues/Tickets
CHNL-5893
CHNL-4970