CHNL-6305: Added set profile attributes bridge method #135
Conversation
example/ios/Podfile.lock
Outdated
| @@ -1379,7 +1379,7 @@ SPEC CHECKSUMS: | |||
| React-utils: debda2c206770ee2785bdebb7f16d8db9f18838a | |||
| ReactCommon: ddb128564dcbfa0287d3d1a2d10f8c7457c971f6 | |||
| SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17 | |||
| Yoga: 2b33a7ac96c58cdaa7b810948fc6a2a76ed2d108 | |||
There was a problem hiding this comment.
not sure why this changed 🤷🏽
| @@ -97,7 +97,9 @@ export const setPushToken = async () => { | |||
|
|
|||
| export const setProfileAttribute = async () => { | |||
| try { | |||
| Klaviyo.setProfileAttribute('CUSTOM', generateRandomName(12)); | |||
| Klaviyo.setProfileAttribute(ProfileProperty.CITY, generateRandomName(5)); | |||
There was a problem hiding this comment.
added a couple properties outside of the custom one so that manual testing is easier.
There was a problem hiding this comment.
Nice.
Yeah I'd love to update this sample app someday to have an input form here instead of just generating random data.
| @@ -82,6 +82,11 @@ public class KlaviyoBridge: NSObject { | |||
| KlaviyoSDK().set(profile: profile) | |||
| } | |||
|
|
|||
| @objc | |||
| public static func setProfileAttribute(_ key: String, value: String) { | |||
| KlaviyoSDK().set(profileAttribute: getProfileKey(key), value: value) | |||
There was a problem hiding this comment.
Doesn't really matter, but in the Android code we just used CUSTOM for all incoming keys 🤷
@ReactMethod
override fun setProfileAttribute(
propertyKey: String,
value: String,
) {
Klaviyo.setProfileAttribute(ProfileKey.CUSTOM(propertyKey), value)
}
|
iOS CI failed because of cached cocoapods mismatching with that lockfile change. I still don't understand why it is using cache if the lockfile changed. But I set off a re-run, which should ignore cache, lets see! EDIT: NVM the re-run succeeded |
Description
During the initial release of our beta react native SDK, we somehow missed bridging methods for
setProfileAttributeson iOS. This PR aims to add those missing bridging methods.Check List
Changelog / Code Overview
Test Plan
Performed manual testing using different profile property attributes such as latitude, longitude, city etc.
Related Issues/Tickets