Updated occurrences of String
to string
#152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In TypeScript,
string
is a primitive type, whileString
is a global object that is a wrapper around the primitivestring
type. We were using both of these interchangeably which could lead to issues like this -The above error is because
getEmail
returns an instance of typeString
whereassetProfile
accepts an instance ofProfile
whose email property is of typestring
.The fix was to across the board using
string
instead ofString
. This in some cases could be a breaking change if developer made any provision in their code to handle this inconsistency. Since we are in beta we will release this change as a minor version update or roll it into our first major version release.Check List
Changelog / Code Overview
Test Plan
Related Issues/Tickets