Reviewed sample app with an eye to android setup instructions and opened push event issues #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndurell
reviewed
May 15, 2024
ndurell
reviewed
May 15, 2024
example/android/app/src/main/java/com/klaviyoreactnativesdkexample/MainActivity.kt
Show resolved
Hide resolved
ndurell
reviewed
May 15, 2024
example/android/app/src/main/java/com/klaviyoreactnativesdkexample/MainApplication.kt
Outdated
Show resolved
Hide resolved
ndurell
reviewed
May 15, 2024
ndurell
approved these changes
May 15, 2024
|
This PR has not seen any updates in the last 16 days. Without further action this PR will be closed in 14 days. To disable further staleness checks add the |
evan-masseau
commented
Jun 4, 2024
example/android/app/src/main/java/com/klaviyoreactnativesdkexample/MainApplication.kt
Outdated
Show resolved
Hide resolved
added 3 commits
June 4, 2024 15:56
…st, had to fix some dependencies and I consolidated where all the configs live at least for android specific
evan-masseau
changed the title
ajaysubra
approved these changes
Jun 4, 2024
evan-masseau
commented
Jun 5, 2024
evan-masseau
commented
Jun 5, 2024
example/android/app/src/main/java/com/klaviyoreactnativesdkexample/MainActivity.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm reviewing the sample app (mostly android) to make sure it contains and explains all the setup steps, similar to what Ajay's already done for iOS. These updates should help people get set up properly to avoid problems with opened push events also.
Check List
Changelog / Code Overview
Test Plan
Related Issues/Tickets
CHNL-7370