CHNL-10057 Note react native firebase sdk capitalization issue #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-peluso
requested review from
kennyklaviyo,
evan-masseau,
ajaysubra and
ab1470
and removed request for
a team
ab1470
approved these changes
Sep 23, 2024
ajaysubra
reviewed
Sep 24, 2024
dan-peluso
force-pushed
the
dan/CHNL-10057-note-firebase-rn-library-troubleshooting
branch
from
5d16114
to
f98e97c
Compare
|
I am going to admin merge this. The CI issue is unrelated, and its just a markdown update that I would like to get into our docs. |
evan-masseau
deleted the
dan/CHNL-10057-note-firebase-rn-library-troubleshooting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a change (issue?) in the react native firebase SDK we use where the push token from APNS is coming back as all caps, where the APNS API is not returning it in this format. This is just an added warning to the readme that describes the issue.
Check List
Changelog / Code Overview
Test Plan
Related Issues/Tickets
CHNL-10057
invertase/react-native-firebase#8022