Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming SDK Name and Version overrides to be more generic #182

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

dan-peluso
Copy link
Contributor

If we're going to support different platforms overriding the native SDK values, we should probably make it named something less "react-native" specific.

I'll open an ios PR to do this on that side as well

@dan-peluso dan-peluso requested a review from a team as a code owner November 12, 2024 20:12
@dan-peluso dan-peluso requested review from ndurell and removed request for a team November 12, 2024 20:12
@@ -13,7 +13,7 @@ Pod::Spec.new do |s|
s.platforms = { :ios => "13.0" }
s.source = { :git => "https://github.com/klaviyo/klaviyo-react-native-sdk.git", :tag => "#{s.version}" }
s.source_files = "ios/**/*.{h,m,mm,swift}"
s.resources = ["ios/klaviyo-react-native-sdk-configuration.plist"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to rename this in the code too no?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nvm - that's in a different repo. 🤦🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

klaviyo/klaviyo-swift-sdk#236

Could use some 👁️ 👁️ tho

@dan-peluso dan-peluso merged commit 2df3f96 into master Nov 13, 2024
9 checks passed
@dan-peluso dan-peluso deleted the dan/sdk-name-version-override-generic branch November 13, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants