Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of Klaviyo Swift SDK #78

Closed
wants to merge 1 commit into from

Conversation

youcefswoo
Copy link

@youcefswoo youcefswoo commented Feb 6, 2024

Description

Fix the compile issue with XCode.

image

Check List

  • Are you changing anything with the public API? No
  • Are your changes backwards compatible with previous SDK Versions? Yes

Changelog / Code Overview

Test Plan

Trying to build using XCode.

Related Issues/Tickets

@youcefswoo youcefswoo requested a review from a team as a code owner February 6, 2024 13:33
@youcefswoo youcefswoo requested review from kennyklaviyo and removed request for a team February 6, 2024 13:33
@youcefswoo youcefswoo changed the title fix import of klaviyo swift sdk Fix import of Klaviyo Swift SDK Feb 6, 2024
@ajaysubra
Copy link
Collaborator

Hey @youcefswoo thanks for reporting your issue and opening the PR. We tried reproducing the issue on our end but we were unable to do so.

We suspect xcode may be encountering issues with the derived data directory where it generates the klaviyo_react_native_sdk-Swift.h file. Please revert your change, clean the build folder (Product > Clean Build Folder), restart Xcode and try to build/run the example iOS app again. Please let us know this resolves the issue.

@evan-masseau
Copy link
Contributor

Going to close based on Ajay's comment and our manual/automated testing. If you try Ajay's steps and still have trouble, please rebase or merge off of master before re-opening your pull request so that you have the latest CI workflow.
Thanks!

@ajaysubra
Copy link
Collaborator

@youcefswoo please refer this issue for more information on this issue. TLDR - although this fix was valid for when you import our SDK as a framework, it would have failed for default cocoapods setup where dependencies are pulled in as static libraries. Release 0.2.1 of this SDK should allow our SDK to work in both the cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants