Added composite builds like android test app, so we can target local copy of SDK instead of jitpack. #9
Conversation
…copy of SDK instead of jitpack.
| @@ -0,0 +1,17 @@ | |||
| // Substitute the jitpack SDK dependency for your local instance of the project | |||
There was a problem hiding this comment.
should this be in android or example/android?
There was a problem hiding this comment.
mm wait nvm this should be here..but feels weird to have this be in the repo since eventually this will be public
There was a problem hiding this comment.
is there a way to add a local settings file instead?
There was a problem hiding this comment.
Thats a good point, this I copied from the android test app repo, since that is private. I don't know of a way to make a private settings file, only local.properties.
I suppose we can just share this internally and not commit it.
There was a problem hiding this comment.
Wonder if it'd be possible to do this in the rn test app... feels like no since that will be importing the node project, but... idk maybe it could work
There was a problem hiding this comment.
Actually that wouldn't help anyways nvm
| @@ -8,7 +8,7 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath "com.android.tools.build:gradle:7.2.1" | |||
| classpath "com.android.tools.build:gradle:7.3.1" | |||
There was a problem hiding this comment.
Had to have matching gradle versions with the SDK
|
Closing due to the very valid point that this would be a little odd to have in the public repo. Could be a useful tool, but not to merge permanently. |
No description provided.